[FEAT] impact 에러 수정 2 - #25
Merged
Merged
Conversation
useNewsQuery()는 실 응답이 오기 전 placeholderData로 mock의 첫 항목을 즉시 보여준다. 이전 수정은 이 placeholder 값으로 selectedNewsId를 그대로 확정해버려서, 실제 응답이 도착한 뒤에도(selectedNewsId가 이미 차 있어 useEffect 가드에 걸림) 갱신되지 않는 문제가 있었다. isPlaceholderData가 false일 때(실제 응답 도착 후)만 firstNewsId를 계산하도록 수정. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Closed
1 task
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough뉴스 쿼리의 Changes뉴스 초기 선택 제어
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👥 작업 배경 및 목적
🛠️ 주요 변경 사항
useNewsQuery()는 실 응답이 오기 전 placeholderData로 mock의 첫 항목을 즉시 보여준다. 이전 수정은 이 placeholder 값으로 selectedNewsId를 그대로 확정해버려서, 실제 응답이 도착한 뒤에도(selectedNewsId가 이미 차 있어useEffect 가드에 걸림) 갱신되지 않는 문제가 있었다.
isPlaceholderData가 false일 때(실제 응답 도착 후)만 firstNewsId를 계산하도록 수정.
🧪 테스트 결과 (선택)
Summary by CodeRabbit