Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes runJs, deduplicates template and adds <noscript> to index.html template #2225

Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Apr 30, 2024

No description provided.

@soywiz soywiz changed the title Fixes runJs, deduplicates template and adds <noscript> to index.html template Fixes runJs, deduplicates template and adds <noscript> to index.html template, changes output to ES2015 Apr 30, 2024
@soywiz
Copy link
Member Author

soywiz commented Apr 30, 2024

ES2015 uses .mjs files, where require() function is not available. Thus we cannot use ES2015 yet unless we update korlibs to not use dynamic require in nodeJS. Maybe we can use import(), and we can check which function (require or import) is available.

@soywiz
Copy link
Member Author

soywiz commented Apr 30, 2024

ES2015 output reduces :korge-sandbox:runJs from 2.5MB to 1.9MB in release mode (esbuild minification without using google closure compiler)

@soywiz soywiz changed the title Fixes runJs, deduplicates template and adds <noscript> to index.html template, changes output to ES2015 Fixes runJs, deduplicates template and adds <noscript> to index.html template Apr 30, 2024
@soywiz soywiz merged commit 53884d2 into main Apr 30, 2024
6 checks passed
@soywiz soywiz deleted the soywiz/fix.runJs.plus.deduplicate.preloader.plus.noscript branch April 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant