Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ASE 9-patch reading in KorGE #2126

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Implement ASE 9-patch reading in KorGE #2126

merged 1 commit into from
Jan 12, 2024

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jan 12, 2024 •
edited
Loading

@soywiz soywiz requested a review from jobe-m January 12, 2024 19:31
@jobe-m
Copy link
Member

jobe-m commented Jan 12, 2024

Awesome, thanks :)
You're really fast. I will try it out next Monday during the stream.
I hope it does not break other features of aseprite file loading.

@soywiz soywiz merged commit 2b01e2f into main Jan 12, 2024
9 checks passed
@soywiz soywiz deleted the feature/support.ASEprite.9patch.reading.in.korge branch January 12, 2024 20:45
@soywiz
Copy link
Member Author

soywiz commented Jan 12, 2024

Awesome, thanks :) You're really fast. I will try it out next Monday during the stream. I hope it does not break other features of aseprite file loading.

It shouldn't. Tests are passing, and there is a good battery of tests there. This is an optional nullable ninePatchSlice that is only created when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobe-m jobe-m Awaiting requested review from jobe-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soywiz @jobe-m