Major: Improved audio stability. Added NewPlatformAudioOutput, providing a callback-based audio generator that is much more stable #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor that is much more stable
soywiz
changed the title
soywiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio generation happens in their own audio-thread, and is generated on demand. It also simplifies implementations.
This implementation was done to circumvent all the limitations of the old K/N memory model. But now K/N is only used on iOS, and we have the new memory model, so we can finally fix how this works.
Took the opportunity to clean-up old backends.
This should fix the choppy sound issues that happened in most targets since ages ago.