Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three-argument document.open() #1925

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Three-argument document.open() #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion korge/src/js/korlibs/render/DialogInterfaceJs.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import org.w3c.files.*
class DialogInterfaceJs : DialogInterface {

override suspend fun browse(url: URL) {
document.open(url.fullUrl)
document.open(url.fullUrl, "", "noopener=true")
Copy link
Member

@soywiz soywiz Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I notice. Shouldn't it be window.open?
https://developer.mozilla.org/en-US/docs/Web/API/Window/open

}

override suspend fun alert(message: String) {
Expand Down
Loading