Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Watchos & Arm32 targets and unify Number.toCgFloat #1843

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Sep 14, 2023

No description provided.

@soywiz soywiz changed the title Remove Arm64 targets and unify Number.toCgFloat Remove Arm32 targets and unify Number.toCgFloat Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.02% 🎉

Comparison is base (a77d344) 51.04% compared to head (a469062) 51.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
+ Coverage   51.04%   51.06%   +0.02%     
==========================================
  Files        1754     1754              
  Lines      103129   103118      -11     
  Branches    14605    14599       -6     
==========================================
+ Hits        52638    52662      +24     
+ Misses      46526    46510      -16     
+ Partials     3965     3946      -19     
Flag Coverage Δ
unittests 51.06% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain/kotlin/korlibs/korge/gradle/targets/Targets.kt 1.96% <0.00%> (+0.14%) ⬆️
...orlibs/korge/gradle/targets/ios/IosProjectTools.kt 0.00% <0.00%> (ø)
...uildSrc/src/main/kotlin/korlibs/modules/Targets.kt 0.00% <ø> (ø)
.../src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt 0.00% <ø> (ø)
...n/src/commonMain/kotlin/korlibs/memory/Platform.kt 58.18% <ø> (+1.03%) ⬆️
...ndation/src/commonMain/kotlin/korlibs/memory/Os.kt 42.85% <50.00%> (+2.85%) ⬆️
...lin/korlibs/image/font/NativeSystemFontProvider.kt 55.90% <100.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soywiz soywiz changed the title Remove Arm32 targets and unify Number.toCgFloat Remove Watchos & Arm32 targets and unify Number.toCgFloat Sep 14, 2023
@soywiz soywiz merged commit eec4721 into main Sep 14, 2023
9 checks passed
@soywiz soywiz deleted the cleanup/remove.arm32.targets branch October 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants