Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor screenshot tester to use offscreen rendering utils. #1819

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

Kietyo
Copy link
Contributor

@Kietyo Kietyo commented Aug 3, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.29% and project coverage change: -0.19% ⚠️

Comparison is base (37e5917) 51.65% compared to head (7160bdc) 51.47%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   51.65%   51.47%   -0.19%     
==========================================
  Files        1750     1750              
  Lines      102821   102826       +5     
  Branches    14521    14519       -2     
==========================================
- Hits        53114    52931     -183     
- Misses      45666    45912     +246     
+ Partials     4041     3983      -58     
Flag Coverage Δ
unittests 51.47% <35.29%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kotlin/korlibs/korge/testing/KorgeOffscreenTest.kt 70.49% <0.00%> (+49.18%) ⬆️
...Main/kotlin/korlibs/korge/testing/testing_utils.kt 17.47% <14.28%> (-2.14%) ⬇️
...ain/kotlin/korlibs/korge/testing/BitmapAsserter.kt 9.16% <66.66%> (+9.16%) ⬆️
...lin/korlibs/korge/testing/KorgeScreenshotTester.kt 78.26% <100.00%> (+2.17%) ⬆️

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kietyo Kietyo merged commit 56e9a4a into korlibs:main Aug 4, 2023
9 checks passed
@Kietyo Kietyo deleted the update_screenshot_tester branch August 4, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants