Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Sandbox samples key input interfering with the main dropdown by making the scene container focusable #1795

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jul 12, 2023

Fixes #1590

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (416f94e) 51.19% compared to head (e559bb9) 51.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   51.19%   51.19%   -0.01%     
==========================================
  Files        1744     1744              
  Lines      102416   102423       +7     
  Branches    14479    14479              
==========================================
  Hits        52431    52431              
- Misses      46048    46059      +11     
+ Partials     3937     3933       -4     
Flag Coverage Δ
unittests 51.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmonMain/kotlin/korlibs/korge/ui/UIFocusManager.kt 35.18% <0.00%> (-5.25%) ⬇️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 1c086e1 into main Jul 12, 2023
10 checks passed
@soywiz soywiz deleted the fix/fix.sandbox.key.input branch October 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In sandbox, any examples with keyboard input doesn't work well because it opens/interacts with the dropdown.
2 participants