Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UIWindow scale handlers + improve close button icon #1776

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jul 6, 2023

No description provided.

@soywiz soywiz enabled auto-merge (squash) July 6, 2023 09:25
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 39.28% and project coverage change: -0.02 ⚠️

Comparison is base (47ad4b9) 51.17% compared to head (86d58f0) 51.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
- Coverage   51.17%   51.16%   -0.02%     
==========================================
  Files        1740     1741       +1     
  Lines      102181   102205      +24     
  Branches    14458    14459       +1     
==========================================
- Hits        52293    52290       -3     
- Misses      45932    45940       +8     
- Partials     3956     3975      +19     
Flag Coverage Δ
unittests 51.16% <39.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/commonMain/kotlin/korlibs/korge/ui/UIIcons.kt 0.00% <0.00%> (ø)
...src/commonMain/kotlin/korlibs/korge/ui/UIWindow.kt 0.00% <0.00%> (ø)
...e/src/commonMain/kotlin/korlibs/korge/view/View.kt 52.71% <0.00%> (-0.07%) ⬇️
.../commonMain/kotlin/korlibs/korge/view/BlendMode.kt 84.12% <100.00%> (+1.07%) ⬆️
...monTest/kotlin/korlibs/korge/view/BlendModeTest.kt 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit c1bece2 into main Jul 6, 2023
10 checks passed
@soywiz soywiz deleted the fix/fix.UIWindow branch October 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants