Fix/alsa wait #1770
Merged
Fix/alsa wait #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, `wait()` was returnign immediately, but `stop()` was not stopping properly (drain, instead of drop), so it had the impression of working.
…iod worth of frames remaining Fixes the issue where sounds where not properly waiting to play before finishing. Would cause only a very small portion of the start of the sound to play.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
- Coverage 51.19% 51.16% -0.04%
==========================================
Files 1740 1740
Lines 102140 102163 +23
Branches 14453 14456 +3
==========================================
- Hits 52294 52270 -24
- Misses 45905 45935 +30
- Partials 3941 3958 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
soywiz
reviewed
Jul 5, 2023
korau/src/commonMain/kotlin/korlibs/audio/sound/backends/ALSA.kt
Outdated
Show resolved
Hide resolved
soywiz
reviewed
Jul 5, 2023
korau/src/commonMain/kotlin/korlibs/audio/sound/backends/ALSA.kt
Outdated
Show resolved
Hide resolved
soywiz
reviewed
Jul 5, 2023
korau/src/commonMain/kotlin/korlibs/audio/sound/backends/ALSA.kt
Outdated
Show resolved
Hide resolved
|
All modification of |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit did fix ALSA not being interruptible, but I notice that it also doesn't cleanly end on it own (i.e. without being interrupted). Specifically,
availableSampleswas not implemented, sowait()always returned immediately. This was not noticed, sincestop()calleddrain()which waits for the written audio to end. This seeks to solve that by:availableSamplessowait()works properlystop()to callsnd_pcm_drop()instead ofsnd_pcm_drain()to immediately drop all remaining frames, instead of waiting for them to finishwait()thenstop()when a sound is donestop()when a sound is cancelledsnd_pcm_delay()to get the number offramesremaining to be heard aftersnd_pcm_writeito determine how long to wait before writing the next sound (or returning, if done).