Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves UIVertical/HorizontalStack behaviour, to compute its size based on their childrens by default #1739

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 30, 2023

Fixes #1735

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 🎉

Comparison is base (a0218b2) 51.13% compared to head (6d9cf85) 51.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
+ Coverage   51.13%   51.15%   +0.01%     
==========================================
  Files        1732     1734       +2     
  Lines      101692   101767      +75     
  Branches    14416    14430      +14     
==========================================
+ Hits        52003    52056      +53     
- Misses      45727    45751      +24     
+ Partials     3962     3960       -2     
Flag Coverage Δ
unittests 51.15% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dbox/src/commonMain/kotlin/samples/MainUIStacks.kt 0.00% <0.00%> (ø)
...Main/kotlin/korlibs/korge/ui/UIContainerLayouts.kt 41.08% <53.84%> (+13.40%) ⬆️
.../kotlin/korlibs/korge/ui/UIContainerLayoutsTest.kt 84.84% <84.84%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit c2dc1d0 into main Jul 1, 2023
9 of 10 checks passed
cmhulbert pushed a commit to cmhulbert/korge that referenced this pull request Jul 1, 2023
…sed on their childrens by default (korlibs#1739)

* Supports not specifying size of ui*Stack and being computed based on the children

* Added UIStacks example
@soywiz soywiz deleted the feat/uistack.improvement branch October 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected result when using uiVerticalStack and uiHorizontalStack
2 participants