Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vector3 & Vector4 abs, min, max & clamp + tests #1713

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 19, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 85.71% and no project coverage change.

Comparison is base (57090d2) 50.94% compared to head (e6b374f) 50.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   50.94%   50.95%           
=======================================
  Files        1727     1728    +1     
  Lines      100928   100994   +66     
  Branches    14333    14339    +6     
=======================================
+ Hits        51419    51461   +42     
- Misses      45578    45580    +2     
- Partials     3931     3953   +22     
Flag Coverage Δ
unittests 50.95% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/commonMain/kotlin/korlibs/math/geom/Vector2.kt 51.04% <54.54%> (+2.08%) ⬆️
...src/commonMain/kotlin/korlibs/math/geom/Vector4.kt 41.53% <62.50%> (+2.94%) ⬆️
...src/commonMain/kotlin/korlibs/math/geom/Vector3.kt 44.44% <66.66%> (+3.17%) ⬆️
...commonTest/kotlin/korlibs/math/geom/VectorsTest.kt 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz enabled auto-merge (squash) June 20, 2023 08:52
@soywiz soywiz disabled auto-merge June 20, 2023 08:52
@soywiz soywiz merged commit 578f78a into main Jun 20, 2023
1 check passed
@soywiz soywiz deleted the feature/add.Vector3.Vector4.min.max.clamp.abs branch October 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants