Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering to BlurFilter & DropShadowFilter & View.maskFiltering #1688

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 12, 2023

No description provided.

@soywiz soywiz changed the title Added filtering to BlurFilter & DropShadowFilter Added filtering to BlurFilter & DropShadowFilter & View.maskFiltering Jun 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 19.04% and project coverage change: +0.01 🎉

Comparison is base (31e2313) 50.96% compared to head (fd692c0) 50.97%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   50.96%   50.97%   +0.01%     
==========================================
  Files        1724     1725       +1     
  Lines      100643   100656      +13     
  Branches    14300    14300              
==========================================
+ Hits        51289    51313      +24     
- Misses      45408    45418      +10     
+ Partials     3946     3925      -21     
Flag Coverage Δ
unittests 50.97% <19.04%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/korlibs/korge/view/filter/DropShadowFilter.kt 0.00% <0.00%> (ø)
...monMain/kotlin/korlibs/korge/view/mask/ViewMask.kt 0.00% <0.00%> (ø)
...ain/kotlin/korlibs/korge/view/filter/BlurFilter.kt 42.10% <25.00%> (-7.90%) ⬇️
...n/korlibs/korge/view/filter/FilterWithFiltering.kt 100.00% <100.00%> (ø)
...n/kotlin/korlibs/korge/view/filter/ShaderFilter.kt 85.88% <100.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz enabled auto-merge (squash) June 12, 2023 04:55
@soywiz soywiz merged commit 2495f22 into main Jun 12, 2023
10 checks passed
@soywiz soywiz deleted the feature/BlurFilter.filtering branch October 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants