Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ViewPropertyProvider, and support ImageDataView.animation selection #1680

Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 8, 2023

Screenshot 2023-06-08 at 11 56 04

@soywiz soywiz enabled auto-merge (squash) June 8, 2023 10:50
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 9.52% and project coverage change: -0.04 ⚠️

Comparison is base (95ddc9a) 50.83% compared to head (de1f416) 50.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   50.83%   50.80%   -0.04%     
==========================================
  Files        1711     1713       +2     
  Lines      100190   100196       +6     
  Branches    14235    14233       -2     
==========================================
- Hits        50933    50900      -33     
- Misses      45368    45378      +10     
- Partials     3889     3918      +29     
Flag Coverage Δ
unittests 50.80% <9.52%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/commonMain/kotlin/korlibs/korge/ui/UIButton.kt 47.13% <ø> (ø)
.../src/commonMain/kotlin/korlibs/korge/ui/UIImage.kt 0.00% <ø> (ø)
.../commonMain/kotlin/korlibs/korge/view/BlendMode.kt 83.05% <ø> (+1.38%) ⬆️
...korlibs/korge/view/StandardViewPropertyProvider.kt 0.00% <0.00%> (ø)
...e/src/commonMain/kotlin/korlibs/korge/view/Text.kt 53.11% <ø> (ø)
.../commonMain/kotlin/korlibs/korge/view/TextBlock.kt 52.30% <ø> (ø)
...e/src/commonMain/kotlin/korlibs/korge/view/View.kt 52.65% <ø> (ø)
...tlin/korlibs/korge/view/animation/ImageDataView.kt 0.00% <0.00%> (ø)
...tlin/korlibs/korge/view/filter/Convolute3Filter.kt 0.00% <0.00%> (ø)
...kotlin/korlibs/korge/view/property/ViewProperty.kt 0.00% <0.00%> (ø)
... and 3 more

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit dd0774a into main Jun 8, 2023
10 checks passed
@soywiz soywiz deleted the feature/animation.dropdown.in.debugger.for.ImageDataView branch October 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants