Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final WASM retake #1677

Merged
merged 16 commits into from
Jun 12, 2023
Merged

Final WASM retake #1677

merged 16 commits into from
Jun 12, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 3, 2023

All tests that are being executed are passing or ignored already. Now it is time to get runWasm actually working. Now it throws a bunch of exceptions.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (5239b87) 50.92% compared to head (90d3d61) 50.98%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   50.92%   50.98%   +0.06%     
==========================================
  Files        1724     1724              
  Lines      100775   100643     -132     
  Branches    14315    14300      -15     
==========================================
- Hits        51321    51316       -5     
+ Misses      45539    45406     -133     
- Partials     3915     3921       +6     
Flag Coverage Δ
unittests 50.98% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...main/kotlin/korlibs/korge/gradle/KorgeExtension.kt 36.00% <0.00%> (-0.40%) ⬇️
...libs/korge/gradle/targets/android/AndroidDirect.kt 0.00% <0.00%> (ø)
...ain/kotlin/korlibs/korge/gradle/targets/js/Wasm.kt 0.00% <0.00%> (ø)
...korlibs/korge/gradle/targets/wasm/ConfigureWasm.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)
...e-sandbox/src/commonMain/kotlin/samples/MainBVH.kt 0.00% <0.00%> (ø)
...ox/src/commonMain/kotlin/samples/MainHelloWorld.kt 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz enabled auto-merge (squash) June 12, 2023 02:10
@soywiz soywiz disabled auto-merge June 12, 2023 03:40
@soywiz soywiz merged commit 31e2313 into main Jun 12, 2023
10 checks passed
@soywiz soywiz deleted the feature/final.retake.wasm branch October 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants