-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM Browser support for all the libraries including korgw and korge (retake) #1628
Conversation
…pending on kotlinx-coroutines" This reverts commit dc04a50.
…dyn and in other targets those values are boxed with the same instance as an optimization
… the tests to hang without displaying errors or reporting anything
In the case of korge removing tests doesn't help. Just by including an empty .kt file in the test source folder it hangs already |
… to see if we can circumvent the error: ~ Uncaught (in promise) CompileError: WebAssembly. instantiateStreaming() : Compiling function async module:63 #41285 :"korlibs.graphics.gl.AGOpenglssget-gla$ref.Invoke" failed: call|el expected type (ref null 11168), found local.get of type (ref null 7114) @+6179170
…Type.ARRAYBUFFER // @todo: Error calling this accessor`
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
- Coverage 51.03% 50.92% -0.12%
==========================================
Files 1692 1691 -1
Lines 99713 99883 +170
Branches 14230 14235 +5
==========================================
- Hits 50890 50864 -26
- Misses 44893 45107 +214
+ Partials 3930 3912 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Retake of #1626
✅
./gradlew :korio:wasmBrowserTest
✅
./gradlew :klock:wasmBrowserTest
✅
./gradlew :kbignum:wasmBrowserTest
✅
./gradlew :kmem:wasmBrowserTest
✅
./gradlew :korte:wasmBrowserTest
✅
./gradlew :korinject:wasmBrowserTest
✅
./gradlew :korau:wasmBrowserTest
✅
./gradlew :krypto:wasmBrowserTest
❌☠️ KDS tests are hanging before even starting:
https://youtrack.jetbrains.com/issue/KT-58941/WASM-Hang-with-extension-delegate-inside-a-Class
❌☠️ KORGW tests are hanging before even starting:
It seems that it was because there was a
fun main
:korlibs.render.main
inKorgwSampleMain.kt
. Are tests running every main method they find?❌☠️ KORGE doesn't have compilation errors but fails when generating the test executable:
Reported here: https://youtrack.jetbrains.com/issue/KT-59061/WASM-CompileError-WebAssembly.instantiateStreaming-korlibs.graphics.gl.AGOpenglssget-glaref.Invoke-failed-callel-expected-type
❌⚠️ Some KORMA tests fails because
Double/Float.toString()
display rounding works differently than in other targets.❌⚠️ Some KORIM tests fails with different things. Not sure if getImageData/putImageData transferred properly ot something else failed. Because in JS IntArray/Int32Array were aliases and thus mirrored, so maybe in some places we will have to ensure when copying we are loading back