-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove experimental wrapped klock variants (#1508)" #1604
Conversation
This reverts commit 982d866.
Hey folks 👋 korlibs-archive/klock#108 @lamba92 @RomeuG are you still using this? I can add the wrapped versions again if it makes sense. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 50.93% 50.83% -0.11%
==========================================
Files 1691 1711 +20
Lines 99887 100190 +303
Branches 14235 14235
==========================================
+ Hits 50873 50927 +54
- Misses 45114 45366 +252
+ Partials 3900 3897 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hi @soywiz! Not anymore, in my case. Thank you for the heads up. |
In the end I'm going to merge it, just in case some people still uses this but didn't see this RFC so they can bump without losing functionality. |
My team is definitely still using this and it actually is preventing us from updating to latest version. BUT we will be migrating away from Klock over the next month so not that big of a deal. |
No worries. Since I'm not sure how much people might be in the same situation, and it is something that can be done easily I think it might benefit other people. Eventually the idea is to use kotlinx.datetime and wrap around that. But in the meantime this can be a solution for those people. |
This reverts commit 982d866.
Would fix #1586
Let's figure out if people is still using it again.