Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove experimental wrapped klock variants (#1508)" #1604

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 15, 2023

This reverts commit 982d866.

Would fix #1586

Let's figure out if people is still using it again.

@soywiz
Copy link
Member Author

soywiz commented May 15, 2023

Hey folks 👋 korlibs-archive/klock#108

@lamba92 @RomeuG are you still using this? I can add the wrapped versions again if it makes sense.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Patch coverage: 15.51% and project coverage change: -0.11 ⚠️

Comparison is base (60af534) 50.93% compared to head (2953edb) 50.83%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   50.93%   50.83%   -0.11%     
==========================================
  Files        1691     1711      +20     
  Lines       99887   100190     +303     
  Branches    14235    14235              
==========================================
+ Hits        50873    50927      +54     
- Misses      45114    45366     +252     
+ Partials     3900     3897       -3     
Flag Coverage Δ
unittests 50.83% <15.51%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nMain/kotlin/korlibs/time/wrapped/WDateTimeSpan.kt 0.00% <0.00%> (ø)
...monMain/kotlin/korlibs/time/wrapped/WDateTimeTz.kt 0.00% <0.00%> (ø)
...mmonMain/kotlin/korlibs/time/wrapped/WDayOfWeek.kt 0.00% <0.00%> (ø)
...c/commonMain/kotlin/korlibs/time/wrapped/WMonth.kt 0.00% <0.00%> (ø)
...ommonMain/kotlin/korlibs/time/wrapped/WTimeSpan.kt 5.71% <5.71%> (ø)
...ommonMain/kotlin/korlibs/time/wrapped/WDateTime.kt 6.55% <6.55%> (ø)
...rc/commonMain/kotlin/korlibs/time/wrapped/WYear.kt 10.52% <10.52%> (ø)
...mmonMain/kotlin/korlibs/time/wrapped/WMonthSpan.kt 12.50% <12.50%> (ø)
...rc/commonMain/kotlin/korlibs/time/wrapped/WDate.kt 14.28% <14.28%> (ø)
...ain/kotlin/korlibs/time/wrapped/WTimezoneOffset.kt 16.66% <16.66%> (ø)
... and 11 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RomeuG
Copy link

RomeuG commented May 15, 2023

Hi @soywiz! Not anymore, in my case. Thank you for the heads up.

@soywiz soywiz enabled auto-merge (squash) June 6, 2023 09:36
@soywiz
Copy link
Member Author

soywiz commented Jun 6, 2023

In the end I'm going to merge it, just in case some people still uses this but didn't see this RFC so they can bump without losing functionality.

@soywiz soywiz merged commit 95ddc9a into main Jun 6, 2023
@dalewking
Copy link

My team is definitely still using this and it actually is preventing us from updating to latest version. BUT we will be migrating away from Klock over the next month so not that big of a deal.

@soywiz
Copy link
Member Author

soywiz commented Jun 6, 2023

No worries. Since I'm not sure how much people might be in the same situation, and it is something that can be done easily I think it might benefit other people. Eventually the idea is to use kotlinx.datetime and wrap around that. But in the meantime this can be a solution for those people.

@soywiz soywiz deleted the feature/restore.klock.wrapped.variants branch October 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back the non-inline wrapper classes
4 participants