Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tests onStageResized / onEvent(ViewsResizedEvent) #1571

Merged
merged 1 commit into from
May 4, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 4, 2023

No description provided.

soywiz added a commit to korlibs/korge-compose that referenced this pull request May 4, 2023
@soywiz soywiz enabled auto-merge (squash) May 4, 2023 22:25
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (e479b66) 51.21% compared to head (67c27c7) 51.23%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   51.21%   51.23%   +0.01%     
==========================================
  Files        1672     1672              
  Lines       98744    98751       +7     
  Branches    14119    14119              
==========================================
+ Hits        50570    50592      +22     
+ Misses      44296    44284      -12     
+ Partials     3878     3875       -3     
Flag Coverage Δ
unittests 51.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/commonMain/kotlin/korlibs/korge/view/Views.kt 63.86% <100.00%> (+0.81%) ⬆️
.../commonTest/kotlin/korlibs/korge/view/ViewsTest.kt 95.89% <100.00%> (+0.10%) ⬆️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 1c040f8 into main May 4, 2023
@soywiz soywiz deleted the fix/fix.onStageResized branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants