Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes empty lines in yaml maps #1570

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented May 4, 2023

Fix from @jobe-m backported from korlibs/kproject#12

@soywiz soywiz requested a review from jobe-m May 4, 2023 11:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (5b97cea) 51.22% compared to head (5aba0d1) 51.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
- Coverage   51.22%   51.21%   -0.02%     
==========================================
  Files        1672     1672              
  Lines       98738    98744       +6     
  Branches    14117    14119       +2     
==========================================
- Hits        50579    50572       -7     
+ Misses      44300    44295       -5     
- Partials     3859     3877      +18     
Flag Coverage Δ
unittests 51.21% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nMain/kotlin/korlibs/io/serialization/yaml/Yaml.kt 81.81% <100.00%> (+0.12%) ⬆️
...t/kotlin/korlibs/io/serialization/yaml/YamlTest.kt 98.30% <100.00%> (+0.02%) ⬆️
...ommonMain/kotlin/korlibs/template/internal/Yaml.kt 81.81% <100.00%> (+0.12%) ⬆️
...src/commonTest/kotlin/korlibs/template/YamlTest.kt 98.30% <100.00%> (+0.02%) ⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit e479b66 into main May 4, 2023
Copy link
Member

@jobe-m jobe-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soywiz soywiz deleted the fix/fix.yaml.empty.lines.on.map branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants