Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds operators to Frequency #1473

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Adds operators to Frequency #1473

merged 3 commits into from
Mar 27, 2023

Conversation

lmvortex4k
Copy link
Contributor

Based on TimeSpan

@@ -9,4 +9,16 @@ class FrequencyTest {
assertEquals(100.milliseconds, 10.timesPerSecond.timeSpan)
assertEquals(10.hz, 100.milliseconds.hz)
}

@Test
fun `test frequency operators work as expected`() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work, since on JS and Android IIRC this might not be valid. Let's wait for CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.27% and project coverage change: +0.01 🎉

Comparison is base (aef326b) 51.58% compared to head (83a94f9) 51.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
+ Coverage   51.58%   51.59%   +0.01%     
==========================================
  Files        1680     1680              
  Lines       98906    98953      +47     
  Branches    13938    13944       +6     
==========================================
+ Hits        51022    51059      +37     
- Misses      44027    44029       +2     
- Partials     3857     3865       +8     
Flag Coverage Δ
unittests 51.59% <77.27%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/src/commonMain/kotlin/korlibs/time/Frequency.kt 58.33% <64.28%> (+3.78%) ⬆️
...rc/commonTest/kotlin/korlibs/time/FrequencyTest.kt 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz enabled auto-merge (squash) March 27, 2023 10:34
@soywiz
Copy link
Member

soywiz commented Mar 27, 2023

LGTM. Thanks! 🎉

@soywiz soywiz merged commit 9d7e33f into korlibs:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants