Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immutable variants for types in Uniforms inside UniformBlock #1470

Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 25, 2023

No description provided.

@soywiz soywiz enabled auto-merge (squash) March 25, 2023 05:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Patch coverage: 55.55% and no project coverage change.

Comparison is base (2368c78) 51.57% compared to head (6c284a5) 51.58%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   51.57%   51.58%           
=======================================
  Files        1680     1680           
  Lines       98906    98906           
  Branches    13938    13938           
=======================================
+ Hits        51014    51018    +4     
- Misses      44024    44030    +6     
+ Partials     3868     3858   -10     
Flag Coverage Δ
unittests 51.58% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/kotlin/korlibs/graphics/shader/UniformBlock.kt 69.53% <55.55%> (ø)

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz disabled auto-merge March 25, 2023 14:31
@soywiz soywiz enabled auto-merge (squash) March 25, 2023 14:31
@soywiz soywiz merged commit aef326b into main Mar 25, 2023
@soywiz soywiz deleted the cleanup/use.immutable.types.as.uniforms.in.uniform.block.types branch October 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants