Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime: Support throwing without adjusting for invalid dates #1447

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 23, 2023

Fixes #1437

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 56.66% and no project coverage change.

Comparison is base (4ac37ef) 51.67% compared to head (8ce736c) 51.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   51.67%   51.68%           
=======================================
  Files        1677     1677           
  Lines       98843    98857   +14     
  Branches    13923    13930    +7     
=======================================
+ Hits        51080    51093   +13     
- Misses      43904    43911    +7     
+ Partials     3859     3853    -6     
Flag Coverage Δ
unittests 51.68% <56.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nMain/kotlin/com/soywiz/klock/PatternTimeFormat.kt 56.52% <ø> (ø)
...c/commonMain/kotlin/com/soywiz/klock/TimeFormat.kt 38.88% <33.33%> (+1.38%) ⬆️
...nMain/kotlin/com/soywiz/klock/PatternDateFormat.kt 89.75% <40.00%> (-2.67%) ⬇️
.../src/commonMain/kotlin/com/soywiz/klock/ISO8601.kt 75.74% <50.00%> (ø)
...c/commonMain/kotlin/com/soywiz/klock/DateFormat.kt 81.81% <100.00%> (+0.86%) ⬆️
...commonTest/kotlin/com/soywiz/klock/DateTimeTest.kt 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit ffc3b05 into main Mar 23, 2023
@soywiz soywiz deleted the fix/unadjusted.invalid.date branch October 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong DateTime is always adjusted by parser, no way to validate date
2 participants