Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ObjectMapper2 interface, make Dynamic2 delegating accessAny to it to support change its behaviour #1433

Merged

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 15, 2023

Fixes #1413

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.02 🎉

Comparison is base (8e9699b) 52.46% compared to head (4b3affd) 52.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
+ Coverage   52.46%   52.49%   +0.02%     
==========================================
  Files        1647     1647              
  Lines       96593    96595       +2     
  Branches    13597    13598       +1     
==========================================
+ Hits        50677    50703      +26     
+ Misses      42114    42090      -24     
  Partials     3802     3802              
Flag Coverage Δ
unittests 52.49% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/com/soywiz/korte/dynamic/ObjectMapper2.kt 50.00% <78.57%> (+31.81%) ⬆️
...onMain/kotlin/com/soywiz/korte/dynamic/Dynamic2.kt 38.81% <100.00%> (-1.68%) ⬇️

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 5ef5689 into main Mar 15, 2023
@soywiz soywiz deleted the feature/support.overriding.accessAny.and.delegating.ObjectMapper2 branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KorTE: Accessing Map's declared properties
2 participants