Replace Console with Logger almost everywhere #1393
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
+ Coverage 51.97% 51.98% +0.01%
==========================================
Files 1644 1644
Lines 99986 99997 +11
Branches 14591 14591
==========================================
+ Hits 51963 51982 +19
+ Misses 43919 43900 -19
- Partials 4104 4115 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -13,7 +13,7 @@ inline fun <T : Any> traceTime(name: String, block: () -> T): T { | |||
| result = block() | |||
| } | |||
| if (traceTimes) { | |||
| Console.info("$name loaded in $time") | |||
| Logger("TraceTime").info { "$name loaded in $time" } | |||
There was a problem hiding this comment.
Maybe @PublishedAPI internal val traceTimeLogger outside the function?
| @@ -163,6 +165,7 @@ private class NodeJsAsyncClient(val coroutineContext: CoroutineContext) : AsyncC | |||
| private class NodeJsAsyncServer : AsyncServer { | |||
| private val net = require_node("net") | |||
| private var server: dynamic = null | |||
| private val logger = Logger("NodeJsAsyncServer") | |||
There was a problem hiding this comment.
Maybe inside a companion object, so the calling happens just once?
There was a problem hiding this comment.
done (also for asyncClient)
|
Nice! Just a couple minor issues. Glad you were able to set it up and overcome the linting that is provably OCR-ish 🤣 and make the PR. It worked well |
|
LGTM. Thanks! |
First time opening a PR on another persons repo on Github, hope I did it right. Also my (pretty strict) Lint plugin really wants to go crazy on this project 😄