Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require ANDROID_TESTS=true for android connected checks #1362

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 23, 2023

It seemed that the "test" sourceSet was not including the assets in the generated test apk

It seemed that the "test" sourceSet was not including the assets in the generated test apk
@codecov-commenter
Copy link

Codecov Report

Base: 52.08% // Head: 52.07% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6530d72) compared to base (a1489a1).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   52.08%   52.07%   -0.01%     
==========================================
  Files        1690     1690              
  Lines      104318   104313       -5     
  Branches    15359    15359              
==========================================
- Hits        54330    54326       -4     
+ Misses      45681    45668      -13     
- Partials     4307     4319      +12     
Flag Coverage Δ
unittests 52.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/com/soywiz/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)
...e/src/commonTest/kotlin/com/soywiz/korge3d/test.kt 80.00% <0.00%> (-20.00%) ⬇️
.../kotlin/com/soywiz/korau/format/AudioFormatTest.kt 88.46% <0.00%> (-11.54%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/ZipVfsTest.kt 77.77% <0.00%> (-11.12%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.47% <0.00%> (-10.53%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 82.75% <0.00%> (-3.45%) ⬇️
...mmonTest/kotlin/com/soywiz/korim/format/ASETest.kt 95.37% <0.00%> (-2.90%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/OGG.kt 69.56% <0.00%> (-2.18%) ⬇️
...ommonTest/kotlin/com/soywiz/korim/font/FontTest.kt 96.66% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit d1e4bb5 into main Feb 23, 2023
@soywiz soywiz deleted the fix/fix.ANDROID_TESTS.requirement branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants