Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU rendering for ShapeView and Circle by default again #1328

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 13, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 51.94% // Head: 51.95% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c052956) compared to base (ad983e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   51.94%   51.95%           
=======================================
  Files        1690     1690           
  Lines      103609   103609           
  Branches    15319    15319           
=======================================
+ Hits        53818    53825    +7     
  Misses      45495    45495           
+ Partials     4296     4289    -7     
Flag Coverage Δ
unittests 51.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../commonMain/kotlin/com/soywiz/korge/view/Circle.kt 86.66% <100.00%> (ø)
...mmonMain/kotlin/com/soywiz/korge/view/ShapeView.kt 73.13% <100.00%> (ø)
...commonTest/kotlin/com/soywiz/korim/font/TTfTest.kt 88.88% <0.00%> (-8.89%) ⬇️
...onTest/kotlin/com/soywiz/korio/vfs/LocalVfsTest.kt 73.77% <0.00%> (-6.56%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 79.31% <0.00%> (-3.45%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/WAV.kt 84.90% <0.00%> (-2.84%) ⬇️
...ain/kotlin/com/soywiz/korim/format/ImageFormats.kt 24.39% <0.00%> (-2.44%) ⬇️
...ommonMain/kotlin/com/soywiz/korge/view/Graphics.kt 54.00% <0.00%> (-2.00%) ⬇️
...est/kotlin/com/soywiz/korim/font/TtfCIDFontTest.kt 96.00% <0.00%> (-2.00%) ⬇️
...est/kotlin/com/soywiz/korge/atlas/AtlasInfoTest.kt 81.48% <0.00%> (-1.86%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Try to upload screenshot test results as artifacts

Try to upload screenshot test results as artifacts

Try to upload screenshot test results as artifacts

Some fixes

Update gpu screenshots

Try to also upload artifacts for other reports
@soywiz soywiz force-pushed the feature/enable.GPU.for.shapeView.by.default.again branch from edb364c to c052956 Compare February 13, 2023 14:46
@soywiz soywiz merged commit 7012eed into main Feb 13, 2023
@soywiz soywiz deleted the feature/enable.GPU.for.shapeView.by.default.again branch October 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants