Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Android and JVM source sets on Klock #1293

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 9, 2023

Fixes #675

@codecov-commenter
Copy link

Codecov Report

Base: 52.68% // Head: 52.70% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b3e52ba) compared to base (e161436).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   52.68%   52.70%   +0.01%     
==========================================
  Files        1691     1692       +1     
  Lines      103435   103437       +2     
  Branches    15262    15262              
==========================================
+ Hits        54492    54513      +21     
+ Misses      44590    44587       -3     
+ Partials     4353     4337      -16     
Flag Coverage Δ
unittests 52.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...AndroidMain/kotlin/com/soywiz/klock/jvm/DateExt.kt 100.00% <ø> (ø)
.../kotlin/com/soywiz/korau/format/AudioFormatTest.kt 84.00% <0.00%> (-12.00%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/IsoVfsTest.kt 77.77% <0.00%> (-11.12%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/ResourcesVfsTest.kt 81.81% <0.00%> (-9.10%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.18% <0.00%> (-8.11%) ⬇️
...est/kotlin/com/soywiz/korge/atlas/AtlasInfoTest.kt 77.77% <0.00%> (-3.71%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/OGG.kt 69.56% <0.00%> (-2.18%) ⬇️
...Test/kotlin/com/soywiz/korge/view/NinePatchTest.kt 95.91% <0.00%> (-2.05%) ⬇️
.../commonMain/kotlin/com/soywiz/korim/format/EXIF.kt 65.47% <0.00%> (-1.20%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/WAV.kt 86.79% <0.00%> (-0.95%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit a06495e into main Feb 9, 2023
@soywiz soywiz deleted the cleanup/klock.unify.android.jvm branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klock: Remove the unnecessary android() target since it has the same implementation as jvm()
2 participants