Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why korlibs-crypto depends on korlibs-time? #2112

Closed
morki opened this issue Jan 2, 2024 · 1 comment · Fixed by #2114
Closed

Why korlibs-crypto depends on korlibs-time? #2112

morki opened this issue Jan 2, 2024 · 1 comment · Fixed by #2114

Comments

@morki
Copy link

morki commented Jan 2, 2024

I did not find any real dependency in code, is it really needed?
@morki morki changed the title Why korlibs-crypto dependes on korlibs-time? Why korlibs-crypto depends on korlibs-time? Jan 2, 2024
@soywiz
Copy link
Member

soywiz commented Jan 3, 2024

Maybe it was an error. Can you make a PR removing the dependency? If CI passess, it should be fine.

InsanusMokrassar added a commit to InsanusMokrassar/korge that referenced this issue Jan 3, 2024
@InsanusMokrassar
remove time from crypto dependencies (korlibs#2112)
822001d
@InsanusMokrassar InsanusMokrassar linked a pull request Jan 3, 2024 that will close this issue
Remove time from crypto dependencies (#2112) #2114
Merged
@soywiz soywiz mentioned this issue Jan 3, 2024
Merged
soywiz pushed a commit that referenced this issue Jan 3, 2024
@InsanusMokrassar
Remove time from crypto dependencies (#2112) (#2114)
813c764 
remove time from crypto dependencies (#2112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Korlibs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove time from crypto dependencies (#2112) InsanusMokrassar/korge
2 participants
@soywiz @morki