-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Krypto buffered stream hashing extension functions #1710
Comments
It is possible to add for InputStream to the JVM yes. Also note that there are extensions for synchronous and asynchronous KorIO streams: korge/korio/src/commonMain/kotlin/korlibs/io/hash/HashExt.kt Lines 14 to 24 in e2081e0
|
I'm not using korio in my project, as I found the lack of documentation on everything to make it significantly more difficult to use. Additionally, I find korio less intuitive to use in comparison to other methods of IO. If it were easier to use and had the documentation significantly improved, I'd be much more inclined to use it over the alternatives. |
I can submit a PR with those additions, if you'd like, however due to how short they were, I felt it'd be easiest to leave it as an issue and let a maintainer add them |
We are shorthanded, so feel free to create a PR. We currently do not have contribution guidelines in place. Therefore, please remember to thoroughly document all public functions and create tests with clear and explicit names. |
I noticed that currently, krypto only has extension functions to compute the hash of a
ByteArray
.However, it is not too difficult to implement said hashing extension functions, and would be a good quality of life inclusion.
Using the JVM-only
InputStream
:There is also okio, which provides
Source
andBufferedSource
:If these could both be included in the jvm only source set, that would be great.
Additionally, extensions for korio can also be included in the common source set.
The text was updated successfully, but these errors were encountered: