URL schemes always lowercase fixes issue #2092 (#2102)

korlibs · Dec 31, 2023 · e7f2a98 · e7f2a98
1 parent e617e70
commit e7f2a98
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/korge-core/src/korlibs/io/net/URL.kt b/korge-core/src/korlibs/io/net/URL.kt
@@ -86,7 +86,7 @@ data class URL private constructor(
 			fragment: String?,
 			opaque: Boolean = false,
 			port: Int = DEFAULT_PORT
-		): URL = URL(opaque, scheme, userInfo, host, path, query, fragment, port)
+		): URL = URL(opaque, scheme?.lowercase(), userInfo, host, path, query, fragment, port)
 
 		private val schemeRegex = Regex("\\w+:")
 

diff --git a/korge-core/test/korlibs/io/net/URLTest.kt b/korge-core/test/korlibs/io/net/URLTest.kt
@@ -100,6 +100,23 @@ class URLTest {
 		for (url in URLS) assertEquals(url.isOpaque, URL(url.url).isOpaque, url.url)
 	}
 
+    @Test
+    fun testURL(){
+        val url = URL("HTTPS://Google.com:442/test?q=1")
+        assertEquals("https", url.scheme) // always lowercase issue #2092
+        assertEquals("Google.com", url.host)
+        assertEquals(442, url.port)
+        assertEquals("/test", url.path)
+        assertEquals("/test?q=1", url.pathWithQuery)
+        assertEquals("q=1", url.query)
+        assertEquals("https://Google.com:442/test?q=1", url.fullUrl)
+
+        val url2 = URL(scheme = "HTTPs", userInfo = null, host = "Google.com", path = "", query = null, fragment = null)
+        assertEquals("https", url2.scheme)
+        assertEquals(443, url2.port)
+        assertEquals("https://Google.com", url2.fullUrl)
+    }
+
     @Test
     fun testNormalize() {
         assertEquals("g", "./g/.".pathInfo.normalize())