Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two latency metrics not using PROMETHEUS_LATENCY_BUCKETS setting #343

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

AleksaC
Copy link
Contributor

@AleksaC AleksaC commented Dec 21, 2022

django_http_requests_latency_including_middlewares_seconds and django_db_query_duration_seconds don't use the PROMETHEUS_LATENCY_BUCKETS setting and also the default for django_http_requests_latency_seconds_by_view_method is not the default that python prometheus client uses.

I used the default that was used for django_http_requests_latency_seconds_by_view_method and moved it to conf module and then used that config in histograms mentioned above.

… django_http_requests_latency_including_middlewares_seconds and django_db_query_duration_seconds histograms
@AleksaC AleksaC changed the title Fix two metrics not using PROMETHEUS_LATENCY_BUCKETS setting Fix two latency metrics not using PROMETHEUS_LATENCY_BUCKETS setting Dec 21, 2022
@asherf
Copy link
Collaborator

asherf commented Jan 23, 2023

thanks.
sorry for the delay.

@asherf asherf merged commit 1733888 into korfuri:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants