Fix two latency metrics not using PROMETHEUS_LATENCY_BUCKETS setting #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… django_http_requests_latency_including_middlewares_seconds and django_db_query_duration_seconds histograms
AleksaC
changed the title
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django_http_requests_latency_including_middlewares_secondsanddjango_db_query_duration_secondsdon't use thePROMETHEUS_LATENCY_BUCKETSsetting and also the default fordjango_http_requests_latency_seconds_by_view_methodis not the default that python prometheus client uses.I used the default that was used for
django_http_requests_latency_seconds_by_view_methodand moved it to conf module and then used that config in histograms mentioned above.