Our Changes to the Sampler for the JPro-Demo-Page #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a link to the online-demo at jpro.one. Added an ambient background to the sampler. The sampler now also works as a jar. Previously, it couldn't properly load the text of the fxml-files.
|
Thank you for the PR, however I'd suggest creating a separate sampler subproject that deals with JPro specifics. What do you think? |
|
You mean as a subproject, which inherits all classes from the original sampler, but contains all the JPro-specific code? I can do that. |
|
Yes. Perhaps a refactor of the existing sampler is needed in order for the JPro sampler to reduce duplication when inserting the top level container. WDYT? |
|
@aalmiray |
aalmiray
approved these changes
Nov 21, 2018
subprojects/sampler-jpro/src/main/java/org/kordamp/bootstrapfx/SamplerJPro.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made some changes to the project to promote it on the JPro-Demo-Page.
It's accessable from the following url: https://demos.jpro.one/bootstrapfx.html
It contains the following changes: