Skip to content

Conversation

@dg0yt
Copy link

@dg0yt dg0yt commented Feb 15, 2023

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qt5-base/portfile.cmake

@dg0yt
Copy link
Author

dg0yt commented Feb 15, 2023

@koprok This should make the build succeed regardless of whether sh is present in PATH or not. If users have msys perl but not sh, it remains unsupported.

Now we have most things from microsoft#20309 ;-)

@dg0yt dg0yt marked this pull request as draft February 15, 2023 09:23
@dg0yt
Copy link
Author

dg0yt commented Feb 15, 2023

Hm, not sure if it is currently doing the right thing for a native x64-linux build...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/qt5-base/portfile.cmake

@dg0yt dg0yt marked this pull request as ready for review February 16, 2023 05:16
@koprok koprok merged commit 9920ea8 into koprok:qt5-mingw Feb 16, 2023
@koprok
Copy link
Owner

koprok commented Feb 16, 2023

@dg0yt, everything looks ok by me again: x64-mingw-dynamic + niXman MinGW, with no sh or perl in path.

@dg0yt
Copy link
Author

dg0yt commented Feb 16, 2023

Thanks @koprok. No more change for me at this point.

@dg0yt dg0yt deleted the qt5-mingw32-make branch February 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants