Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Valhalla #692

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to Valhalla #692

wants to merge 4 commits into from

Conversation

koppor
Copy link
Owner

@koppor koppor commented Aug 3, 2024

Prepares the usage of Valhalla.

Reason: String!. See https://bugs.openjdk.org/browse/JDK-8303099.

Won't work, because of gradle toolchain lacking support for JDK23. See https://docs.gradle.org/current/userguide/compatibility.html.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Owner Author

koppor commented Aug 3, 2024

Err, even though it should not work, there are artifacts produced at https://github.com/koppor/jabref/actions/runs/10223502907?pr=692

@koppor
Copy link
Owner Author

koppor commented Aug 4, 2024

Runs:

image

I only don't get, why 5.12 is displayed as version - and not v5.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants