feat(16355): remove error image and adjust error styles

[Natallia-Harshunova]

https://kontur.fibery.io/Tasks/My-tasks-3575#Task/Remove-icon-from-error-messages-on-DN-panels-16355

[coderabbitai]

Walkthrough

The recent changes focus on enhancing the ErrorMessage component by replacing the marginTop prop with margin and containerClass props. This update ensures more flexible and consistent styling across different components. Additionally, various components have been updated to utilize these new props, improving the visual consistency and simplifying the rendering logic for error messages.

Changes

Files	Change Summary
src/components/ErrorMessage/ErrorMessage.tsx	Replaced marginTop prop with margin and containerClass props for better styling control.
src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx	Updated error rendering to include new styling for ErrorMessage and imported a CSS module.
src/features/analytics_panel/components/AnalyticsContainer/AnalyticsContainer.tsx	Added margin style property to ErrorMessage for error rendering.
src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx	Simplified ErrorMessage usage by removing the marginTop prop.
src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx	Simplified rendering logic and refactored error message rendering by removing the marginTop prop.
src/components/ErrorMessage/ErrorMessage.module.css	Renamed .spinner class to .errorContainer and adjusted margin using CSS variables.
src/features/events_list/components/FullState/FullState.module.css	Added a new CSS class .errorContainer with a margin-top property.
src/features/events_list/components/FullState/FullState.tsx	Modified error handling logic to include additional styling for ErrorMessage.

Poem

In the code, a change did bloom,
Error messages find more room.
Margin props now take their place,
With styles that bring a touch of grace.
Components now in harmony,
A rabbit's joy, so plain to see.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Language	To Recheck	Fuzzy	Untranslated	Total
ar	3	24	101	128
de	2	24	101	127
es	3	24	101	128
id	2	24	101	127
ko	3	24	101	128
uk	0	7	8	15

[github-actions]

Bundle size diff

Old size	New size	Diff
4.9 MB	4.89 MB	-11.87 KB (-0.24%)

[coderabbitai]

Actionable comments posted: 2

Outside diff range and nitpick comments (1)

src/features/analytics_panel/components/AnalyticsContainer/AnalyticsContainer.tsx (1)

Line range hint 28-28: Replace == with === for strict equality check.

-        ('features' in geometry && geometry.features.length == 0)
+        ('features' in geometry && geometry.features.length === 0)

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8c5d5f6 and 81739b3.

Files ignored due to path filters (1)

• src/components/ErrorMessage/error-state-img.png is excluded by !**/*.png, !**/*.png

Files selected for processing (5)

• src/components/ErrorMessage/ErrorMessage.tsx (1 hunks)
• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx (1 hunks)
• src/features/analytics_panel/components/AnalyticsContainer/AnalyticsContainer.tsx (1 hunks)
• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx (1 hunks)
• src/features/events_list/components/FullState/FullState.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx

Additional Context Used

Biome (3)

src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx (2)

29-29: Use === instead of ==.
== is only allowed when comparing against null

---

32-32: Use === instead of ==.
== is only allowed when comparing against null

src/features/analytics_panel/components/AnalyticsContainer/AnalyticsContainer.tsx (1)

28-28: Use === instead of ==.
== is only allowed when comparing against null

Additional comments not posted (3)

src/features/analytics_panel/components/AnalyticsContainer/AnalyticsContainer.tsx (1)

23-23: The usage of the ErrorMessage component with the new margin prop is correct.

src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx (1)

24-26: The usage of the ErrorMessage component with the new margin prop is correct.

src/features/events_list/components/FullState/FullState.tsx (1)

72-74: The usage of the ErrorMessage component with the new margin prop is correct.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (2)

Line range hint 35-35: The useEffect hook should include all its dependencies to ensure it behaves correctly. Consider adding updateDimensions to the dependency array.

-  useEffect(updateDimensions, [containerRef]);
+  useEffect(updateDimensions, [containerRef, updateDimensions]);

---

Line range hint 54-54: The useEffect hook specifies containerRef as a dependency unnecessarily. Since containerRef is a ref and does not change, it should not trigger re-renders or re-executions of this effect.

-  useEffect(updateDimensions, [containerRef]);
+  useEffect(updateDimensions, []);

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 81739b3 and 7c6d03a.

Files selected for processing (3)

• src/components/ErrorMessage/ErrorMessage.tsx (1 hunks)
• src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (1 hunks)
• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/components/ErrorMessage/ErrorMessage.tsx
• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx

Additional Context Used

Biome (2)

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (2)

35-35: This hook does not specify all of its dependencies: updateDimensions

---

54-54: This hook specifies more dependencies than necessary: containerRef

Additional comments not posted (2)

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (2)

72-72: The removal of the marginTop prop aligns with the PR's objective to adjust error styles. This simplifies the component and adheres to the new styling approach.

---

Line range hint 90-104: The PanelHeader function is well-implemented, using conditional rendering based on the geometry state effectively.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c6d03a and f221e57.

Files selected for processing (1)

• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (2)

Line range hint 35-35: Ensure all dependencies are specified in the useEffect hook.

-  useEffect(updateDimensions, [containerRef]);
+  useEffect(updateDimensions, [updateDimensions]);

This change ensures that the effect correctly re-runs if updateDimensions changes, adhering to React's exhaustive dependencies rule.

---

Line range hint 54-54: Remove unnecessary dependencies from the useEffect hook.

-  useEffect(updateDimensions, [containerRef]);
+  useEffect(updateDimensions, []);

Since updateDimensions does not depend on containerRef, it should not be included in the dependency array.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f221e57 and 2064573.

Files selected for processing (7)

• src/components/ErrorMessage/ErrorMessage.module.css (1 hunks)
• src/components/ErrorMessage/ErrorMessage.tsx (1 hunks)
• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.module.css (1 hunks)
• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx (2 hunks)
• src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (1 hunks)
• src/features/events_list/components/FullState/FullState.module.css (1 hunks)
• src/features/events_list/components/FullState/FullState.tsx (1 hunks)

Files skipped from review due to trivial changes (3)

• src/components/ErrorMessage/ErrorMessage.module.css
• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.module.css
• src/features/events_list/components/FullState/FullState.module.css

Files skipped from review as they are similar to previous changes (3)

• src/components/ErrorMessage/ErrorMessage.tsx
• src/features/advanced_analytics_panel/components/AdvancedAnalyticsContainer/AdvancedAnalyticsContainer.tsx
• src/features/events_list/components/FullState/FullState.tsx

Additional context used

Biome

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx

[error] 35-35: This hook does not specify all of its dependencies: updateDimensions

---

[error] 54-54: This hook specifies more dependencies than necessary: containerRef

Additional comments not posted (1)

src/features/bivariate_manager/components/BivariateMatrixContainer/BivariateMatrixContainer.tsx (1)

70-74: Updated usage of ErrorMessage aligns with PR objectives.

The change from marginTop to containerClass for styling flexibility is correctly implemented here, matching the PR's goal of enhancing error message styling.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2064573 and d87006a.

Files selected for processing (1)

• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/features/event_episodes/components/EpisodesTimelinePanel/EpisodesTimelinePanel.tsx