feat(bivariate-color-manager): 10929 - implemented sublist #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@propakov looks like link to task not correct |
Akiyamka
reviewed
Jul 25, 2022
...bivariate_color_manager/components/SentimentsCombinationsList/SentimentsCombinationsList.tsx
Outdated
Show resolved
Hide resolved
Akiyamka
reviewed
Jul 25, 2022
| <CSSTransition {...props} nodeRef={nodeRef}> | ||
| <> | ||
| {Children.map(children, (child) => | ||
| isValidElement(child) ? cloneElement(child, { ref: nodeRef }) : child, |
There was a problem hiding this comment.
Be careful with cloneElement, is expensive operation, but here it clone only one children - tr, so it should be okay
There was a problem hiding this comment.
do you know a better way of passing some prop to children?
maybe render function pattern would work better?
<CSSTransitionWrapper
in={rowSelected}
timeout={300}
unmountOnExit
appear
classNames={fadeClassNames}
>
(ref) =>
<tr ref={ref} className={s.sublist}>
Akiyamka
approved these changes
Jul 25, 2022
sorry, last digit has lost |
propakov
force-pushed
the
10929-sublist-new
branch
from
ee25d52
to
586fa49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kontur.fibery.io/Tasks/Task/Sublist-with-indicators-(Color-legends-section)-dn-fe-10929
9