fix(18441): redirect to Atlas login after registration in Keycloak #724
Conversation
WalkthroughThis update focuses on modifying the authentication flow within the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Bundle size diff
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/features/user_profile/components/LoginForm/LoginForm.tsx (1 hunks)
Additional comments not posted (2)
src/features/user_profile/components/LoginForm/LoginForm.tsx (2)
14-14: Ensure the new redirect URI aligns with intended user flow and security policies.
14-14: The integration of the new registration URL appears correct. Please ensure thorough testing, especially for edge cases in the redirection flow.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- src/features/user_profile/components/LoginForm/LoginForm.tsx (1 hunks)
Additional comments not posted (2)
src/features/user_profile/components/LoginForm/LoginForm.tsx (2)
15-15: Ensure that the new redirect URL is correct.The
registrationUrlEncodedvariable has been updated to redirect tohttps://atlas.kontur.io/active/profile. Verify that this URL is the intended destination and that it is functioning as expected.Verification successful
Verification successful.
The new redirect URL
https://atlas.kontur.io/active/profileis correct and functioning as expected, returning a status code of 200.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new redirect URL is correct and functioning. # Test: Perform a HTTP request to the new URL. Expect: Status code 200. curl -o /dev/null -s -w "%{http_code}\n" "https://atlas.kontur.io/active/profile"Length of output: 85
16-16: Ensure that the new redirect URL is correct.The
registrationUrlvariable has been updated to redirect tohttps://atlas.kontur.io/active/profile. Verify that this URL is the intended destination and that it is functioning as expected.Verification successful
Verification successful.
The
registrationUrlvariable has been correctly updated to redirect tohttps://atlas.kontur.io/active/profile. The URL is active and functioning as expected.
- The
keycloakUrlandkeycloakRealmvalues are correctly set in the configuration.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new redirect URL is correct and functioning. # Test: Perform a HTTP request to the new URL. Expect: Status code 200. curl -o /dev/null -s -w "%{http_code}\n" "https://atlas.kontur.io/active/profile"Length of output: 85
Script:
#!/bin/bash # Search for occurrences of 'registrationUrl' to understand its context and ensure it is the correct URL. rg 'registrationUrl'Length of output: 510
Script:
#!/bin/bash # Search for occurrences of 'configRepo' to understand how 'keycloakUrl' and 'keycloakRealm' are set. rg 'configRepo'Length of output: 12849
Script:
#!/bin/bash # Search for the definition and implementation of the 'ConfigRepository' class in the 'src/core/config' directory. rg 'class ConfigRepository' src/core/configLength of output: 95
Script:
#!/bin/bash # Extract the full implementation of the 'ConfigRepository' class from 'src/core/config/index.ts'. ast-grep --lang typescript --pattern $'class ConfigRepository { $$$ }' src/core/config/index.tsLength of output: 3399
Script:
#!/bin/bash # Search for occurrences of 'stageConfig' and 'appConfig' to understand their values and ensure they are correctly set. rg 'stageConfig|appConfig'Length of output: 2836
Script:
#!/bin/bash # Search for the 'getStageConfig' function implementation in 'src/core/config/loaders/stageConfigLoader.ts'. rg 'getStageConfig' src/core/config/loaders/stageConfigLoader.tsLength of output: 127
Script:
#!/bin/bash # Extract the full implementation of the 'getStageConfig' function from 'src/core/config/loaders/stageConfigLoader.ts'. ast-grep --lang typescript --pattern $'export async function getStageConfig(): Promise<StageConfig> { $$$ }' src/core/config/loaders/stageConfigLoader.tsLength of output: 2813
alesiahil
changed the title
alesiahil
deleted the
18441-redirect-to-atlas-login-after-registration-in-keycloak
branch
Summary by CodeRabbit