fix bug: event id is removed from request for app with limited ammount of features #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case when event list disabled as feature
We have more cases when auto select unnesasary. Because of this I decide run autoselect only if explicitly required this commit broke auto focus to event
I use the very same logick as for autoselect
Akiyamka
force-pushed
the
10982-event-id-is-removed-from-request-for-app-with-limited-ammount-of-features
branch
from
d5ea61f
to
e6fc23e
Compare
propakov
approved these changes
Jul 7, 2022
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason of this bug was in autoselect logic (look at first commit in branch)
In scope of this fix i rewrite logic of autoselect and autozoom to more imperative style - look like it this case it more suitable