Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event_list): change tooltip style #448

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

dqunbp
Copy link
Contributor

@dqunbp dqunbp commented Feb 15, 2023

@IlyaIzr
Copy link
Contributor

IlyaIzr commented Feb 16, 2023

  1. Task says "Add tooltip «Open timeline» for play button" - i don't see that on the code
  2. Branch doesn't run locally
    image

Code that is presented so far looks good

@propakov
Copy link
Contributor

@IlyaIzr on my pc runs ok locally

change disaster card stats tooltip style
add tooltip to timeline button
move translatons for severity from common to event_list key
@dqunbp dqunbp force-pushed the 14451-change-tooltips-style-on-disaster-card branch from e8a13d0 to 77960b7 Compare February 16, 2023 19:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #448 (e8be4ef) into main (02b8455) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   11.82%   11.81%   -0.02%     
==========================================
  Files         561      561              
  Lines       40186    40226      +40     
  Branches     1198     1198              
==========================================
  Hits         4753     4753              
- Misses      34984    35024      +40     
  Partials      449      449              
Impacted Files Coverage Δ
...components/SeverityIndicator/SeverityIndicator.tsx 0.00% <0.00%> (ø)
...ts/EpisodeTimelineToggle/EpisodeTimelineToggle.tsx 0.00% <0.00%> (ø)
..._list/components/EventCard/Analytics/Analytics.tsx 0.00% <0.00%> (ø)

@propakov
Copy link
Contributor

propakov commented Feb 17, 2023

Have lots of warnings in console when just open the map without any actions
And timeline's 'Play button' tooltip not working
Screenshot 2023-02-17 at 09 25 22

@propakov
Copy link
Contributor

propakov commented Feb 17, 2023

could you also please make SEVERITY_TO_TEXT as a function that returns translation, or put this const inside the component?
i18.n should be called from component, not just on app start
now it's a bug (try to show tooltip after lng switch):
Screenshot 2023-02-17 at 09 42 55

Move severity translations to fn
Update analytycs translation fn
@dqunbp
Copy link
Contributor Author

dqunbp commented Feb 17, 2023

could you also please make SEVERITY_TO_TEXT as a function that returns translation, or put this const inside the component? i18.n should be called from component, not just on app start now it's a bug (try to show tooltip after lng switch): Screenshot 2023-02-17 at 09 42 55

Now we don't have a translation for this

@dqunbp
Copy link
Contributor Author

dqunbp commented Feb 17, 2023

Have lots of warnings in console when just open the map without any actions And timeline's 'Play button' tooltip not working Screenshot 2023-02-17 at 09 25 22

Fixed, targetRef prop was skipped

@propakov
Copy link
Contributor

could you also please make SEVERITY_TO_TEXT as a function that returns translation, or put this const inside the component? i18.n should be called from component, not just on app start now it's a bug (try to show tooltip after lng switch): Screenshot 2023-02-17 at 09 42 55

Now we don't have a translation for this

yeah, but it will work after translation appear, so no problem here 👍

Copy link
Contributor

@propakov propakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍
Found one minor improvement

@dqunbp dqunbp merged commit e591d80 into main Feb 20, 2023
@Akiyamka Akiyamka deleted the 14451-change-tooltips-style-on-disaster-card branch October 23, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants