fix(analytics): 14294 - prevent init of analytics with empty features #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kontur.fibery.io/Tasks/Task/After-several-updates-the-initial-state-of-the-analytics-panel-becomes-advanced-analytics-14294
Context:
Reason of a bug being created - sometimes Analytics initial state is full though it's short set.
After investigation with @Akiyamka we found that the reason is featureFlags being {} at the moment of defining initialState prop:
initialState={featureFlags[FeatureFlag.ANALYTICS_PANEL] ? 'short' : null}
When initialState prop is null, in useShortPanelState it's 'full'.
const initialState = props?.initialState ?? 'full';
So main line here in fix is
just to render layout after we have features filled.