Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): 13368 auth flow fix #344

Merged
merged 15 commits into from
Jan 3, 2023
Merged

fix(core): 13368 auth flow fix #344

merged 15 commits into from
Jan 3, 2023

Conversation

vkozio
Copy link
Contributor

@vkozio vkozio commented Dec 28, 2022 •
edited
Loading

https://kontur.fibery.io/Tasks/Task/Auth-flow-fix-13368

additionally:
non-breaking deps updates
debug improved

Komzpa
Komzpa approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@Komzpa Komzpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run. Added code looks more understandable than removed code.

src/core/app_config/index.ts Outdated Show resolved Hide resolved
src/core/metrics/constants.ts Show resolved Hide resolved
@vkozio vkozio marked this pull request as ready for review December 30, 2022 05:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022 •
edited
Loading

Codecov Report

Merging #344 (d6c2a1e) into main (b59b3d0) will decrease coverage by 0.30%.
The diff coverage is 19.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   11.63%   11.33%   -0.31%     
==========================================
  Files         537      541       +4     
  Lines       38703    38816     +113     
  Branches     1132     1122      -10     
==========================================
- Hits         4505     4398     -107     
- Misses      33765    33972     +207     
- Partials      433      446      +13
Impacted Files Coverage Δ
src/App.tsx 0.00% <0.00%> (ø)
src/components/ConnectedMap/ConnectedMap.tsx 0.00% <0.00%> (ø)
src/core/apiClientInstance.ts 0.00% <0.00%> (-90.25%) ⬇️
src/core/app/authHooks.ts 0.00% <0.00%> (ø)
src/core/app/features.ts 0.00% <0.00%> (ø)
src/core/app/index.ts 0.00% <0.00%> (ø)
src/core/app/init.ts 0.00% <0.00%> (ø)
src/core/app/types.ts 0.00% <0.00%> (ø)
src/core/app_config/loader.ts 0.00% <0.00%> (ø)
src/core/auth/atoms/userWasLanded.ts 0.00% <0.00%> (ø)
... and 98 more

@Komzpa
Copy link
Member

Komzpa commented Dec 30, 2022

Given the size and invasiveness of this, could we add tests on some 15 more lines of code to make codecov happy?

propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/App.tsx Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/init.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/init.ts Outdated Show resolved Hide resolved
@vkozio vkozio requested a review from IlyaIzr December 30, 2022 09:15
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/App.tsx Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/features.ts Outdated Show resolved Hide resolved
propakov
propakov reviewed Dec 30, 2022
View reviewed changes
src/core/app/features.ts Outdated Show resolved Hide resolved
IlyaIzr
IlyaIzr reviewed Jan 1, 2023
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
IlyaIzr
IlyaIzr reviewed Jan 1, 2023
View reviewed changes
src/core/app/authHooks.ts Outdated Show resolved Hide resolved
@vkozio vkozio merged commit 9ec0334 into main Jan 3, 2023
@vkozio vkozio deleted the 13368-auth-flow-fix branch January 3, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Komzpa Komzpa Komzpa approved these changes

@propakov propakov propakov left review comments

@IlyaIzr IlyaIzr IlyaIzr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vkozio @codecov-commenter @Komzpa @propakov @IlyaIzr