Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): 12130 & 12146 - Folding panels with new header design #163

Merged
merged 19 commits into from
Sep 19, 2022

Conversation

IlyaIzr
Copy link
Contributor

@IlyaIzr IlyaIzr commented Sep 14, 2022

image
we still use icons for mobile viewports
image

Copy link
Member

@Komzpa Komzpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots LGTM

@Komzpa
Copy link
Member

Komzpa commented Sep 14, 2022

> [email protected] lint:css
> stylelint ./src/**/*.css


src/features/events_list/components/EventsListPanel/EventsListPanel.module.css
 74:1  ✖  Unexpected duplicate selector ".panelBody", first used at line 1  no-duplicate-selectors

@Akiyamka
Copy link
Contributor

Akiyamka commented Sep 15, 2022

is that expected?

Nope, i didn't even noticed while working on it :D Will fix it with max height it has before

@IlyaIzr
Copy link
Contributor Author

IlyaIzr commented Sep 15, 2022

Sorry, i edited comment above ⬆️ while wanted to reply to it. I'll fix analytics height

@Akiyamka
Copy link
Contributor

image
something bad with legend paddings

src/global.css Outdated Show resolved Hide resolved
Copy link
Contributor

@propakov propakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something wrong happens when open bivariate matrix
image

@propakov
Copy link
Contributor

another moment I found
as it was a custom close button on bivariate panel, need to fix header panel position a bit

._header_pgs27_5 {
position: absolute;
right: 10px;
top: 0px;
...
}

Screenshot 2022-09-16 at 16 20 57

src/global.css Outdated Show resolved Hide resolved
src/global.css Outdated Show resolved Hide resolved
@IlyaIzr IlyaIzr merged commit a571ca4 into main Sep 19, 2022
@Akiyamka Akiyamka deleted the 12130-update-panel-header-component-to-match-design branch October 23, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants