Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panels): 12116 - add modal view for panels in mobile mode and differ it from collapse state #155

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

IlyaIzr
Copy link
Contributor

@IlyaIzr IlyaIzr commented Sep 12, 2022

Not sure whether i should make

{isOpen && isMobile ? (
        <Modal onModalCloseCallback={onPanelClose} className={s.modalCover}>
          {panel}
        </Modal>
      ) : (
        panel
      )}

as a component. Should I?

Examples:
image
image
image
image
image
image

@IlyaIzr IlyaIzr self-assigned this Sep 12, 2022
Copy link
Member

@Komzpa Komzpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots LGTM.

Copy link
Contributor

@propakov propakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚀
add few optional moments to check

@IlyaIzr IlyaIzr merged commit 0bebb15 into main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants