Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10838 filter by sentiments combinations color legends section dn fe #128

Merged
merged 17 commits into from
Aug 31, 2022
Merged

10838 filter by sentiments combinations color legends section dn fe #128

merged 17 commits into from
Aug 31, 2022

Conversation

andrei-kucherov
Copy link
Contributor

image

@andrei-kucherov andrei-kucherov self-assigned this Aug 30, 2022
@propakov
Copy link
Contributor

Screenshot 2022-08-30 at 17 56 11

one visual moment, placeholders have different colors

propakov
propakov reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@propakov propakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I found some moments that we possibly can improve. Pls consider my suggestions, maybe it's ok.

@andrei-kucherov andrei-kucherov merged commit f72947b into main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaIzr IlyaIzr IlyaIzr left review comments

@propakov propakov propakov approved these changes

Assignees

@andrei-kucherov andrei-kucherov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-kucherov @propakov @IlyaIzr