17999 Get application asset through endpoint

[palina-krukovich]

Summary by CodeRabbit

• New Features
  • Introduced a feature to retrieve application assets by language and filename, enhancing user experience with localized content.
• Enhancements
  • Added language acceptance functionality to HTTP client configurations, allowing for more personalized content delivery based on user language preferences.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing asset retrieval and language support across the application. A new method for fetching assets by appId and filename has been introduced, alongside specific imports replacing wildcards for better clarity. Language acceptance is now integrated into HTTP client configurations, with a new interceptor to manage Accept-Language headers, ensuring content is aptly localized. Overall, these changes aim to refine asset management and improve user experience through language customization.

Changes

File Path	Change Summary
.../client/UserProfileClient.java	Added getAsset method; replaced wildcard imports with specific ones.
.../config/WebConfiguration.java	Introduced AcceptLanguageInterceptor for userProfileRestTemplate; added acceptLanguageInterceptor bean.
.../config/interceptor/AcceptLanguageInterceptor.java	New file; implements ClientHttpRequestInterceptor to add Accept-Language header.
.../controller/AppsController.java	Enhanced to retrieve application assets by language and filename.
.../dto/AssetDto.java	New DTO class AssetDto for asset attributes.
.../service/ApplicationService.java	Added getAsset method to fetch an AssetDto based on appId and filename.

🐇✨
In the land of code and byte,
Where the rabbits hop with might,
Changes bloom like spring in sight,
Assets fetched, both day and night.
Languages dance, in headers bright,
Bringing users pure delight.
🌟📚🌍

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a5b4d5c and 07b218e.

Files selected for processing (6)

• src/main/java/io/kontur/disasterninja/client/UserProfileClient.java (3 hunks)
• src/main/java/io/kontur/disasterninja/config/WebConfiguration.java (4 hunks)
• src/main/java/io/kontur/disasterninja/config/interceptor/AcceptLanguageInterceptor.java (1 hunks)
• src/main/java/io/kontur/disasterninja/controller/AppsController.java (4 hunks)
• src/main/java/io/kontur/disasterninja/dto/AssetDto.java (1 hunks)
• src/main/java/io/kontur/disasterninja/service/ApplicationService.java (2 hunks)

Additional comments not posted (7)

src/main/java/io/kontur/disasterninja/dto/AssetDto.java (1)

1-23: The AssetDto class is well-structured and uses appropriate data types for its fields. The use of Lombok annotations helps reduce boilerplate code, enhancing readability and maintainability.

However, ensure that the byte[] asset field is handled securely, especially if the asset data comes from untrusted sources or is exposed to clients directly. Consider validating or sanitizing the data as necessary to prevent security vulnerabilities.

src/main/java/io/kontur/disasterninja/config/interceptor/AcceptLanguageInterceptor.java (1)

1-31: The implementation of AcceptLanguageInterceptor correctly propagates the Accept-Language header from incoming to outgoing requests, supporting content localization effectively.

This is a good practice for applications serving a global user base, ensuring that content can be delivered in the user's preferred language.

src/main/java/io/kontur/disasterninja/service/ApplicationService.java (1)

56-62: The getAsset method in ApplicationService is correctly implemented, using Optional<AssetDto> for null safety and checking the response status code.

Consider adding logging for unexpected response statuses to aid in debugging and ensure that all potential issues are accounted for.

src/main/java/io/kontur/disasterninja/client/UserProfileClient.java (1)

152-155: The getAsset method in UserProfileClient is correctly implemented, using the appropriate URL pattern and handling authentication and caching considerations.

The shift from wildcard imports to specific imports, although not directly visible in the provided code segment, is a good practice that improves code readability and maintainability.

src/main/java/io/kontur/disasterninja/controller/AppsController.java (1)

147-162: The getAsset method in AppsController is well-implemented, correctly handling asset retrieval and setting the appropriate content type headers.

Ensure that the media type and subtype are validated or sanitized to prevent header injection vulnerabilities. This is crucial for maintaining the security of the application.

src/main/java/io/kontur/disasterninja/config/WebConfiguration.java (2)

128-135: The addition of the AcceptLanguageInterceptor to the userProfileRestTemplate bean is correctly implemented, enhancing the application's support for content localization.

This change effectively ensures that outgoing requests respect the Accept-Language header, which is crucial for applications serving a global user base.

---

205-208: The definition of the acceptLanguageInterceptor bean is correctly implemented, facilitating the easy injection of the interceptor into the userProfileRestTemplate.

This setup follows best practices for Spring configuration and enhances the application's internationalization support.

[coderabbitai]

Actionable comments posted: 3

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 07b218e and 8996828.

Files selected for processing (3)

• src/main/java/io/kontur/disasterninja/config/WebConfiguration.java (4 hunks)
• src/main/java/io/kontur/disasterninja/config/interceptor/UserLanguageInterceptor.java (1 hunks)
• src/main/java/io/kontur/disasterninja/controller/AppsController.java (4 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/main/java/io/kontur/disasterninja/config/WebConfiguration.java
• src/main/java/io/kontur/disasterninja/controller/AppsController.java