-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add inheritedParameterContexts option to NiFi ParameterCo… #475
fix(helm): add inheritedParameterContexts option to NiFi ParameterCo… #475
Conversation
And can you regenerate the Helm doc using helm docs? cd helm/nifi-cluster
helm-docs |
Co-authored-by: Juldrixx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move it to ### Added
instead of ### Fixed Bugs
.
And put a capital letter on Chart
in [Helm chart]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it in the Unreleased
section at the beginning of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the field in values.yaml
too with a comment that will be part of the generated documentation like it's done for secretRefs
and parameters
.
@juldrixx thanks for quick review and patience. I think it's in a spot where it can be reviewed again when you have time. |
Thanks for your contribution🙌. |
What's in this PR?
This change will add the option to include inheritedParameterContexts in nifi-parameter-context helm template
Why?
Inherited parameter contexts were not being deployed as expected due to the missing field in the Helm template.
Checklist
To Do