Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to override nifi.properties configmap and secret in Helm … #455

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Add ability to override nifi.properties configmap and secret in Helm … #455

merged 4 commits into from
Sep 4, 2024

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Sep 3, 2024 •
edited
Loading

…chart

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets #462
License Apache 2.0

What's in this PR?

Add ability to set overrideSecretConfig and overrideConfigMap in NifiCluster Helm chart for nifi.properties.

Why?

To allow the user to provide their own Secret or ConfigMap to use a unique one through multiple cluster.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 September 3, 2024 14:32
@juldrixx juldrixx merged commit 15bd8cf into master Sep 4, 2024
2 of 3 checks passed
@juldrixx juldrixx deleted the feat/helm_nificluster_nifiproperties_override branch September 4, 2024 06:50
@juldrixx juldrixx mentioned this pull request Sep 25, 2024
Closed
@juldrixx juldrixx linked an issue Sep 25, 2024 that may be closed by this pull request
[nifi-cluster] cluster.nifiProperties.overrideSecretConfig is ignored when configured #462
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdrix erdrix Awaiting requested review from erdrix

@mh013370 mh013370 Awaiting requested review from mh013370

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nifi-cluster] cluster.nifiProperties.overrideSecretConfig is ignored when configured
1 participant
@juldrixx