Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataflow version type #431

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented May 22, 2024

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Update of NiGoApi to v0.1.1 to change the type of the version field in VersionControlInformationEntity from int32 to interface{}.

Why?

Because starting 2.0.0-M3 the field version is a string but in the previous version it's a int32. So to be compatible with newer and older version we need to use a generic type.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 May 22, 2024 10:53
@juldrixx juldrixx merged commit 7912450 into master May 23, 2024
5 checks passed
@juldrixx juldrixx deleted the patch/change_dataflow_version_type branch May 30, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants