Change secret update detection to be based on resourceVersion #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juldrixx
requested review from
mh013370 and
erdrix
and removed request for
mh013370
juldrixx
deleted the
change_nifi_parameter_context_secret_update_detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Change in the secret update detection to be based on
resourceVersionand not themanagedFields.Why?
In some cases, the
managedFieldswon't be updated if the operation that leads to the secret update is the same as the previous one. It seems to a limitation in some Kubernetes version like 1.21.So to be compatible with as much as possible Kubernetes version, the logic will be changed to watch the
resourceVersionof the different secrets.Checklist