Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nifiuser certificate creation #424

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented May 16, 2024

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Remove set of last applied annotation on creation in Reconcile loop.

Why?

In resource creation the fields set to the resource are forbidden like the resourceVersion and lead to creation failure.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 May 16, 2024 08:40
@juldrixx juldrixx marked this pull request as ready for review May 16, 2024 08:46
@juldrixx juldrixx requested review from mh013370 and removed request for mh013370 May 29, 2024 08:21
@juldrixx juldrixx merged commit 43c0304 into master May 30, 2024
1 check passed
@juldrixx juldrixx deleted the fix_nifiuser_certificate_creation branch May 30, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant